Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Saving bookmarks in the zim-split splitted ZIM files are crashing the application, when there is a 0 size extra zim chunk. #3862

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Fixes #3861

  • Catching the exception thrown by the libkiwix with splitted ZIM files when there is a 0 size extra zim chunk so that the application will not crash when libkiwix throw this type of errors.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 55.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 53.81%. Comparing base (94feb77) to head (9447868).
Report is 11 commits behind head on main.

Current head 9447868 differs from pull request most recent head 7849021

Please upload reports for the commit 7849021 to get more accurate results.

Files Patch % Lines
.../kiwix/kiwixmobile/core/main/CoreReaderFragment.kt 55.00% 2 Missing and 7 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3862      +/-   ##
============================================
- Coverage     53.86%   53.81%   -0.06%     
+ Complexity     1376     1374       -2     
============================================
  Files           298      298              
  Lines         11308    11310       +2     
  Branches       1495     1496       +1     
============================================
- Hits           6091     6086       -5     
- Misses         4226     4233       +7     
  Partials        991      991              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ing the application, when there is a 0 size extra zim chunk.

* Catching the exception thrown by the libkiwix with splitted ZIM files when there is an 0 size extra zim chunk.
@kelson42 kelson42 merged commit 019c675 into main Jun 7, 2024
8 checks passed
@kelson42 kelson42 deleted the Fixe#3861 branch June 7, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants