-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: application was crashing when starting the kiwix server
.
#3846
Conversation
kiwix server
.kiwix server
.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3846 +/- ##
============================================
- Coverage 54.00% 53.79% -0.22%
+ Complexity 1328 1327 -1
============================================
Files 292 292
Lines 11079 11119 +40
Branches 1471 1480 +9
============================================
- Hits 5983 5981 -2
- Misses 4112 4152 +40
- Partials 984 986 +2 ☔ View full report in Codecov by Sentry. |
* Added a check for checking the `MANAGE_EXTERNAL_STORAGE` permission when starting the server in the non-playStore variant. If there is no permission, then it ask for the permission to avoid the crash due to permission lack for file.
…r in all variants and all versions of Android so that it will ask storage(read/write) permission for below Android 13 in non-playStore variant. Also, ask for the `MANAGE_EXTERNAL_STORAGE` permission in Android 11 and above. This check ensures that without the storage and `MANAGE_EXTERNAL_PERMISSION` user can not start the server.
…r, since we have an issue with split zim files of `zim-tools`. Due to this issue, there is crash reported on the playStore. Because we have full access to files in the playStore variant since all the files are located in the `app-specific` directory. * Improved the log for showing the actual error if there is something goes wrong while adding the book in `Library`.
775fa11
to
e48e46b
Compare
@MohitMaliFtechiz So we agree that this bug appears only if we have an empty chunk ofmzim file? |
@kelson42 Yes, in the PS version this bug only happens if there is an empty chunk. For the non-PS version, there is this type of error because of a lack of permission(if the user intentionally disabled the permission) so here in this PR, we are fixing both issues. |
Fixes #3845
MANAGE_EXTERNAL_STORAGE
permission when starting the server in the non-playStore variant. If there is no permission, then it asks for permission to avoid the crash due to permission lack for file.MANAGE_EXTERNAL_STORAGE
permission in Android 11 and above. This check ensures that without the storage andMANAGE_EXTERNAL_PERMISSION
user can not start the server. Because if the application does not have storage permission then it crashes when creating theArchive
object.zim-tools
Zim-tools
version3.3.0
splitted zim files givingCorrupted block detected
error when there is a 0 size extra ZIM chunk. #3827. Due to this issue, there is a crash reported on the playStore. Because we have full access to files in the playStore variant since all the files are located in theapp-specific
directory.IssueeWithSplitZimFiles.mp4
FixServerIssueWithSplitZimFiles.mp4
Library
.