Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Error on opening a split zim file on external storage. #3803

Merged
merged 6 commits into from
May 8, 2024
Merged

Fixed: Error on opening a split zim file on external storage. #3803

merged 6 commits into from
May 8, 2024

Commits on May 8, 2024

  1. Error on opening a split zim file on external storage. 

     * Added test cases for testing that the ZimFileReader can open the splitted zim file or not.
    @MohitMaliDeveloper @kelson42
    MohitMaliDeveloper authored and kelson42 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    b8971e1 View commit details
    Browse the repository at this point in the history

  2. Capturing the better exception when getting the mediaCount and `art… 

    …icleCount` because it was throwing `java.lang.Exception` with splitted zim file when the zim file is corrupted. If there is any zim file is corrupted and libzim throws this exception then our UI will not show the other zim file on `LocalLibraryScreen` due to the getting zim files process being crashed.
    @MohitMaliDeveloper @kelson42
    MohitMaliDeveloper authored and kelson42 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    9cb881b View commit details
    Browse the repository at this point in the history

  3. Added comments if libzim throw exception for articleCount and mediaCo… 

    …unt this will necessary to catch the all exception thrown by libzim to prevent the aborting of the rendering process of other zim files.
    @MohitMaliDeveloper @kelson42
    MohitMaliDeveloper authored and kelson42 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    326b390 View commit details
    Browse the repository at this point in the history

  4. Simplified the creation of splitted zim file.

    @MohitMaliDeveloper @kelson42
    MohitMaliDeveloper authored and kelson42 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    c0912de View commit details
    Browse the repository at this point in the history

  5. Added test case for testing splitted zim file with zero size file.

    @MohitMaliDeveloper @kelson42
    MohitMaliDeveloper authored and kelson42 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    96debf9 View commit details
    Browse the repository at this point in the history

  6. Corrected the comment for handling the exception.

    @MohitMaliDeveloper @kelson42
    MohitMaliDeveloper authored and kelson42 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    ecf74ed View commit details
    Browse the repository at this point in the history