Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libzim 9.2.1-1 & libkiwix 13.1.0-3 #98

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Conversation

kelson42
Copy link
Contributor

@kelson42 kelson42 commented Jun 5, 2024

No description provided.

@MohitMaliFtechiz
Copy link
Collaborator

MohitMaliFtechiz commented Jun 6, 2024

@kelson42 manyLinux file is for the aarch64 libzim_linux-aarch64-manylinux-9.2.1-1.tar.gz, we should use libzim_linux-x86_64-9.2.1-1.tar.gz as it is for the x86_64. I have tested it locally, and it is building the bindings, and test cases are running successfully(Mainly the linux file is for the test cases).

Screenshot from 2024-06-06 15-31-07

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.23%. Comparing base (7fc2c1a) to head (4747f3a).

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #98   +/-   ##
=========================================
  Coverage     93.23%   93.23%           
  Complexity      237      237           
=========================================
  Files            47       47           
  Lines           325      325           
  Branches          3        3           
=========================================
  Hits            303      303           
  Misses           19       19           
  Partials          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 merged commit 4601d78 into main Jun 6, 2024
4 checks passed
@kelson42 kelson42 deleted the new-libkiwix-libzim-builds branch June 6, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants