-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for SDK 34. #97
Conversation
* Upgraded the gradle to support the Android 14. * Made the changes in code to adapt the new gradle. * Rectify the deprecated code that are not working in new version of gradle.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
=========================================
Coverage 93.23% 93.23%
Complexity 237 237
=========================================
Files 47 47
Lines 325 325
Branches 3 3
=========================================
Hits 303 303
Misses 19 19
Partials 3 3 ☔ View full report in Codecov by Sentry. |
@MohitMaliFtechiz All checkd pass, ready to merge? |
@MohitMaliFtechiz BTW what the diadvantage if we keep 24 as minimum? Please also have a look to CI log there is far too many errors and warnings ro my taste. |
* Changed the minimum SDK version to 24.
There is no any disadvantage to keeping the 24 as the minimum API level. I have changed the minimum API level to 24.
@kelson42 I have fixed the warnings reported by the gradle. Apart from these gradle warnings, there are now |
@MohitMaliFtechiz Can you please configure that gradle/tests to fail if we have exceptions in CI? |
@kelson42 You mean warnings(Right)? since Gradle automatically fails the task when there is an error. We can add the |
No, I mean java exceptions |
…ill automatically fail the CI when compiling the project if there is any error in project.
@kelson42 I have added the lint to our project which will fail the CI if any potential error is detected(e.g. gradle and code-related errors). |
Fixes #90
io.github.gradle-nexus:publish-plugin
to2.0.0
.org.jetbrains.kotlin:kotlin-gradle-plugin
to1.9.20
.