Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for SDK 34. #97

Merged
merged 4 commits into from
May 13, 2024
Merged

Added support for SDK 34. #97

merged 4 commits into from
May 13, 2024

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented May 13, 2024

Fixes #90

  • Upgraded the Gradle to support the Android 14.
  • Made the changes in code to adapt the new gradle.
  • Rectify the deprecated code that is not working in the new version of Gradle.
  • Upgraded the minimum SDK version to 24.
  • Upgraded the io.github.gradle-nexus:publish-plugin to 2.0.0.
  • Upgraded the org.jetbrains.kotlin:kotlin-gradle-plugin to 1.9.20.
  • Enabled the lint in our project to avoid potential errors. The lint will automatically fail the CI when compiling the project if there is any error in project.

* Upgraded the gradle to support the Android 14.
* Made the changes in code to adapt the new gradle.
* Rectify the deprecated code that are not working in new version of gradle.
@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft May 13, 2024 10:30
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.23%. Comparing base (40f17fd) to head (ad78cf2).

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #97   +/-   ##
=========================================
  Coverage     93.23%   93.23%           
  Complexity      237      237           
=========================================
  Files            47       47           
  Lines           325      325           
  Branches          3        3           
=========================================
  Hits            303      303           
  Misses           19       19           
  Partials          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42
Copy link
Contributor

@MohitMaliFtechiz All checkd pass, ready to merge?

@kelson42 kelson42 added this to the 2.2.0 milestone May 13, 2024
@kelson42 kelson42 self-requested a review May 13, 2024 10:59
@kelson42
Copy link
Contributor

kelson42 commented May 13, 2024

@MohitMaliFtechiz BTW what the diadvantage if we keep 24 as minimum? Please also have a look to CI log there is far too many errors and warnings ro my taste.

@MohitMaliFtechiz
Copy link
Collaborator Author

@MohitMaliFtechiz BTW what the diadvantage if we keep 24 as minimum?

There is no any disadvantage to keeping the 24 as the minimum API level. I have changed the minimum API level to 24.

Please also have a look to CI log there is far too many errors and warnings ro my taste.

@kelson42 I have fixed the warnings reported by the gradle. Apart from these gradle warnings, there are now cpp deprecations warnings showing on the CI logs. I think @mgautierfr better know about this, maybe these are necessary for compiling. However, we have the ticket for these warnings #92, so we can move forward with this PR.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review May 13, 2024 11:28
@kelson42
Copy link
Contributor

@MohitMaliFtechiz Can you please configure that gradle/tests to fail if we have exceptions in CI?

@MohitMaliFtechiz
Copy link
Collaborator Author

MohitMaliFtechiz commented May 13, 2024

@MohitMaliFtechiz Can you please configure that gradle/tests to fail if we have exceptions in CI?

@kelson42 You mean warnings(Right)? since Gradle automatically fails the task when there is an error. We can add the lint here which checks the project's errors and warnings. Apart from this, should we also fail the build when there is a deprecation warning in the cpp code?

@kelson42
Copy link
Contributor

No, I mean java exceptions

…ill automatically fail the CI when compiling the project if there is any error in project.
@MohitMaliFtechiz
Copy link
Collaborator Author

@MohitMaliFtechiz Can you please configure that gradle/tests to fail if we have exceptions in CI?
No, I mean java exceptions

@kelson42 I have added the lint to our project which will fail the CI if any potential error is detected(e.g. gradle and code-related errors).

@kelson42 kelson42 merged commit 7fc2c1a into main May 13, 2024
4 checks passed
@kelson42 kelson42 deleted the Fix#90 branch May 13, 2024 14:28
@MohitMaliFtechiz MohitMaliFtechiz mentioned this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support and test against SDK 34
3 participants