Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use libzim 9.2.1 #94

Merged
merged 4 commits into from
May 2, 2024
Merged

Use libzim 9.2.1 #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a24e6ff
use libzim 9.2.1
kelson42 May 2, 2024
5396f36
Update workflow actions
kelson42 May 2, 2024
33044e4
Fix error message
kelson42 May 2, 2024
7391792
Add CODECOV_TOKEN usage
kelson42 May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up JDK 11
uses: actions/setup-java@v2
uses: actions/setup-java@v4
with:
distribution: adopt
java-version: 11
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up JDK 11
uses: actions/setup-java@v2
uses: actions/setup-java@v4
with:
distribution: adopt
java-version: 11
Expand All @@ -31,10 +31,12 @@ jobs:
run: ./gradlew createCodeCoverageReport

- name: Upload code coverage to Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}

- name: Upload Coverage to GH-Actions
uses: actions/upload-artifact@v2.2.0
uses: actions/upload-artifact@v4
if: ${{ always() }}
with:
name: Tests Coverage Report
Expand Down
2 changes: 1 addition & 1 deletion lib/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ ext {

// Replace these versions with the latest available versions of libkiwix and libzim
ext.libkiwix_version = "13.1.0-1"
ext.libzim_version = "9.2.0"
ext.libzim_version = "9.2.1"

apply from: 'publish.gradle'
android {
Expand Down
4 changes: 2 additions & 2 deletions lib/src/test/test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,9 +234,9 @@ public void testNonExistant() {
String zimFile = "non_existant.zim";
try {
TestArchive archive1 = new TestArchive(zimFile);
fail("ERROR: Archive created with invalid Zim file!");
fail("ERROR: Archive created with invalid ZIM file!");
} catch (Exception e) {
assertEquals("error 2 opening file \"" + zimFile + "\"", e.getMessage());
assertEquals("Error opening as a split file: " + zimFile, e.getMessage());
}
}

Expand Down