Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zim::Archive to be created with a set of File descriptor. #87

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

mgautierfr
Copy link
Member

This PR is in Draft as it wrap a feature in libzim not yet released.
Once new libzim is released, we have still have to change gradle script to use it and then we should be good.

@kelson42
Copy link
Contributor

@MohitMaliFtechiz I have rebased the PR. It seems it should work. Would you be able to give a try to the new primitive to see if it does the job correctly for Kiwix Android?

@kelson42 kelson42 added this to the 2.1.0 milestone Apr 20, 2024
@kelson42 kelson42 marked this pull request as ready for review April 20, 2024 12:16
@MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz I have rebased the PR. It seems it should work. Would you be able to give a try to the new primitive to see if it does the job correctly for Kiwix Android?

@kelson42 Sure. But here is a compilation error with this new feature of libzim, we first have to fix this issue.

@mgautierfr
Copy link
Member Author

Thanks for your fix @MohitMaliFtechiz

I have update the PR with fix (including yours) and tests. Should be good.
Please review (and understand how to use 🙂)

@MohitMaliFtechiz
Copy link
Collaborator

@mgautierfr Thanks for fixing the remaining part and for adding the test cases. I have tested this libzim feature and it is working in kiwix android, libzim able to load the zim file with list of fd.

@kelson42 kelson42 merged commit 6109a7a into main Apr 22, 2024
2 checks passed
@kelson42 kelson42 deleted the fds_archive branch April 22, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants