Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.2 #79

Merged
merged 7 commits into from
Jan 18, 2024
Merged

Release 1.0.2 #79

merged 7 commits into from
Jan 18, 2024

Conversation

kelson42
Copy link
Contributor

No description provided.

@kelson42
Copy link
Contributor Author

@mgautierfr I have tried to remove getSize() to support latest version of libzim, but it seems we have other problems. Could you please have a look please?

@mgautierfr
Copy link
Member

@MohitMaliDeveloper, The CI is failing at Install dependencies step. The error message is

This version only understands SDK XML versions up to 2 but an SDK XML file of version 3 was encountered. This can happen if you use versions of Android Studio and the command-line tools that were released at different times.

Then a backtrace about 33x not being a number (I agree with that, but don't get from where 33x comes from). And then plenty of other error message (I let you read them at https://github.com/kiwix/java-libkiwix/actions/runs/7232262963/job/20270039324)

Do you have an idea ?

@MohitMaliFtechiz
Copy link
Collaborator

@mgautierfr CI is failing on compile project, let me check what going on here.

@mgautierfr
Copy link
Member

The CI is failing of the compile project, but with make[2]: *** No rule to make target 'libkiwix.so', needed by 'libkiwix_wrapper.so'. Stop. (line 239).

This is because the Install Dependencies has failed (without being an error to stop the CI, which is another problem).

@MohitMaliFtechiz MohitMaliFtechiz self-assigned this Jan 18, 2024
…s available for renaming.

* We have incorporated an additional validation check to verify the existence of the file during the copy/rename process. By default, the copy operation does not raise an error if the source file is unavailable.
@MohitMaliFtechiz
Copy link
Collaborator

MohitMaliFtechiz commented Jan 18, 2024

@mgautierfr Thanks this is the problem with the version of libkiwix we have put here 13.0.0-1. This version archive is available on the https://download.kiwix.org/release/libkiwix/. But internally it has version 13.0.0 as shown in the below image. I think this is obvious because libkiwix has not any release of 13.0.0-1 that why inside the folder it has the 13.0.0 version.

Or somehow there are any differences in these .so files of different versions(13.0.0 and 13.0.0-1)?

Screenshot from 2024-01-18 18-03-39

This is because the Install Dependencies has failed (without being an error to stop the CI, which is another problem).

Thanks, I have improved this now CI is failing on the Install Dependencies task with error message, see https://github.com/kiwix/java-libkiwix/actions/runs/7570603587/job/20616281022?pr=79#step:4:3514.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38373f9) 92.54% compared to head (2714211) 92.51%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #79      +/-   ##
============================================
- Coverage     92.54%   92.51%   -0.03%     
+ Complexity      219      218       -1     
============================================
  Files            45       45              
  Lines           295      294       -1     
  Branches          3        3              
============================================
- Hits            273      272       -1     
  Misses           19       19              
  Partials          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgautierfr
Copy link
Member

Version 13.0.0-1 means it is the second build (the first one being 13.0.0) of the release 13.0.0. We do this when we change the dependencies (for example, libzim) but we don't change the release of the project (libkiwix).

We should use the -n to download the archive but don't use it once we have the archive as internal files inside it will not have it.

@MohitMaliFtechiz
Copy link
Collaborator

@mgautierfr Thanks, I was not aware of this. Now I understand this properly, I am making changes according to this.

* Improved the code to extract the actual version if the archive is from the second build.
@MohitMaliFtechiz
Copy link
Collaborator

@mgautierfr I have modified the code to adapt this change, and updated the libkiwix version to 13.0.0-1.

@mgautierfr
Copy link
Member

Thanks for the fix !

@mgautierfr mgautierfr merged commit 4a8e966 into main Jan 18, 2024
4 checks passed
@mgautierfr mgautierfr deleted the release-1.0.2 branch January 18, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants