-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.0.2 #79
Release 1.0.2 #79
Conversation
@mgautierfr I have tried to remove getSize() to support latest version of libzim, but it seems we have other problems. Could you please have a look please? |
@MohitMaliDeveloper, The CI is failing at
Then a backtrace about Do you have an idea ? |
@mgautierfr CI is failing on |
The CI is failing of the This is because the |
…s available for renaming. * We have incorporated an additional validation check to verify the existence of the file during the copy/rename process. By default, the copy operation does not raise an error if the source file is unavailable.
@mgautierfr Thanks this is the problem with the version of Or somehow there are any differences in these
Thanks, I have improved this now CI is failing on the |
…ilable on the libkiwix repo.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
============================================
- Coverage 92.54% 92.51% -0.03%
+ Complexity 219 218 -1
============================================
Files 45 45
Lines 295 294 -1
Branches 3 3
============================================
- Hits 273 272 -1
Misses 19 19
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Version We should use the |
@mgautierfr Thanks, I was not aware of this. Now I understand this properly, I am making changes according to this. |
* Improved the code to extract the actual version if the archive is from the second build.
@mgautierfr I have modified the code to adapt this change, and updated the libkiwix version to |
Thanks for the fix ! |
No description provided.