Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not put binary illustration data into a string. #74

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

mgautierfr
Copy link
Member

Java String must contains utf8 content.
Illusration data which is PNG is definitively not a utf8 string.

Fix #73

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (853233a) 92.38% compared to head (ed6a302) 92.54%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #74      +/-   ##
============================================
+ Coverage     92.38%   92.54%   +0.15%     
- Complexity      213      219       +6     
============================================
  Files            44       45       +1     
  Lines           289      295       +6     
  Branches          3        3              
============================================
+ Hits            267      273       +6     
  Misses           19       19              
  Partials          3        3              
Files Coverage Δ
...src/main/java/org/kiwix/libkiwix/Illustration.java 100.00% <ø> (ø)
lib/src/test/org/kiwix/test/libkiwix/TestBook.java 96.15% <100.00%> (ø)
...test/org/kiwix/test/libkiwix/TestIllustration.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgautierfr mgautierfr marked this pull request as draft November 9, 2023 13:39
@mgautierfr mgautierfr force-pushed the no_string_for_illustration_data branch 6 times, most recently from d70a276 to 57f8ee6 Compare November 9, 2023 15:25
@mgautierfr mgautierfr marked this pull request as ready for review November 9, 2023 15:47
Java String must contains utf8 content.
Illusration data which is PNG is definitively not a utf8 string.

Fix #73
@kelson42 kelson42 force-pushed the no_string_for_illustration_data branch from 57f8ee6 to ed6a302 Compare November 9, 2023 17:00
@kelson42
Copy link
Contributor

kelson42 commented Nov 9, 2023

@mgautierfr Thank you for the quick response!
@MohitMaliDeveloper Test and review. If OK, prepare the release 1.0.1 (see the ticket).

Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgautierfr Thanks for your quick fix, now the issue is resolved 🎉 🎉, i am able to get the favicon from the book.

LGTM.

@kelson42 kelson42 merged commit f1bcd87 into main Nov 10, 2023
4 checks passed
@kelson42 kelson42 deleted the no_string_for_illustration_data branch November 10, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Illustration.getData() does not provide the Illustration for book.
3 participants