Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to new api introduced in kiwix/libkiwix#991 #68

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

mgautierfr
Copy link
Member

@mgautierfr mgautierfr commented Aug 23, 2023

Fixes #77

@kelson42
Copy link
Contributor

I would wait before merging this that we release first 1.0.0

@kelson42
Copy link
Contributor

This is also needed for libkiwix13 and we still rely on libkiwix12… so we shoukd still wait

@kelson42 kelson42 added this to the 1.1.0 milestone Nov 10, 2023
@mgautierfr mgautierfr mentioned this pull request Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f2470d) 92.54% compared to head (3ddfeb8) 92.54%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #68   +/-   ##
=========================================
  Coverage     92.54%   92.54%           
  Complexity      219      219           
=========================================
  Files            45       45           
  Lines           295      295           
  Branches          3        3           
=========================================
  Hits            273      273           
  Misses           19       19           
  Partials          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgautierfr mgautierfr merged commit 38373f9 into main Nov 20, 2023
4 checks passed
@mgautierfr mgautierfr deleted the adapt_libkiwix_991 branch November 20, 2023 16:20
@kelson42 kelson42 removed this from the 2.1.0 milestone Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to libkiwix 13
2 participants