Fix SuggestionIterator hasNext. #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=========================================
Coverage 92.38% 92.38%
Complexity 213 213
=========================================
Files 44 44
Lines 289 289
Branches 3 3
=========================================
Hits 267 267
Misses 19 19
Partials 3 3 ☔ View full report in Codecov by Sentry. |
MohitMaliFtechiz
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
@mgautierfr, Thanks for you quick fix, now SuggestionIterator.hasNext() method giving output as expected.
MohitMaliFtechiz
pushed a commit
to kiwix/kiwix-android
that referenced
this pull request
Aug 8, 2023
After addressing the issue documented in kiwix/java-libkiwix#61, we now have the ability to search within zim files that do not have a Xapian index. As a result, we have enhanced our test to utilize pre-existing zim files. This improvement leads to reduced time consumption, improved memory efficiency, and minimized network usage impact.
MohitMaliFtechiz
pushed a commit
to kiwix/kiwix-android
that referenced
this pull request
Aug 17, 2023
After addressing the issue documented in kiwix/java-libkiwix#61, we now have the ability to search within zim files that do not have a Xapian index. As a result, we have enhanced our test to utilize pre-existing zim files. This improvement leads to reduced time consumption, improved memory efficiency, and minimized network usage impact.
kelson42
pushed a commit
to kiwix/kiwix-android
that referenced
this pull request
Aug 27, 2023
After addressing the issue documented in kiwix/java-libkiwix#61, we now have the ability to search within zim files that do not have a Xapian index. As a result, we have enhanced our test to utilize pre-existing zim files. This improvement leads to reduced time consumption, improved memory efficiency, and minimized network usage impact.
kelson42
pushed a commit
to kiwix/kiwix-android
that referenced
this pull request
Aug 28, 2023
After addressing the issue documented in kiwix/java-libkiwix#61, we now have the ability to search within zim files that do not have a Xapian index. As a result, we have enhanced our test to utilize pre-existing zim files. This improvement leads to reduced time consumption, improved memory efficiency, and minimized network usage impact.
kelson42
pushed a commit
to kiwix/kiwix-android
that referenced
this pull request
Aug 29, 2023
After addressing the issue documented in kiwix/java-libkiwix#61, we now have the ability to search within zim files that do not have a Xapian index. As a result, we have enhanced our test to utilize pre-existing zim files. This improvement leads to reduced time consumption, improved memory efficiency, and minimized network usage impact.
kelson42
pushed a commit
to kiwix/kiwix-android
that referenced
this pull request
Aug 31, 2023
After addressing the issue documented in kiwix/java-libkiwix#61, we now have the ability to search within zim files that do not have a Xapian index. As a result, we have enhanced our test to utilize pre-existing zim files. This improvement leads to reduced time consumption, improved memory efficiency, and minimized network usage impact.
MohitMaliFtechiz
pushed a commit
to kiwix/kiwix-android
that referenced
this pull request
Sep 5, 2023
After addressing the issue documented in kiwix/java-libkiwix#61, we now have the ability to search within zim files that do not have a Xapian index. As a result, we have enhanced our test to utilize pre-existing zim files. This improvement leads to reduced time consumption, improved memory efficiency, and minimized network usage impact.
kelson42
pushed a commit
to kiwix/kiwix-android
that referenced
this pull request
Sep 18, 2023
After addressing the issue documented in kiwix/java-libkiwix#61, we now have the ability to search within zim files that do not have a Xapian index. As a result, we have enhanced our test to utilize pre-existing zim files. This improvement leads to reduced time consumption, improved memory efficiency, and minimized network usage impact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.