Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed CMAKE_ANDROID_STL_TYPE to shared #53

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Changed CMAKE_ANDROID_STL_TYPE to shared #53

merged 1 commit into from
Aug 25, 2023

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Changed CMAKE_ANDROID_STL_TYPE to shared since it is not recommended to use static when we are using multiple dynamic libraries See conversation #51.

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (197777d) 92.38% compared to head (db79e70) 92.38%.
Report is 1 commits behind head on main.

❗ Current head db79e70 differs from pull request most recent head c314d48. Consider uploading reports for the commit c314d48 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #53   +/-   ##
=========================================
  Coverage     92.38%   92.38%           
  Complexity      213      213           
=========================================
  Files            44       44           
  Lines           289      289           
  Branches          3        3           
=========================================
  Hits            267      267           
  Misses           19       19           
  Partials          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 requested a review from mgautierfr July 27, 2023 14:55
@kelson42
Copy link
Contributor

@mgautierfr Can we merge this?

…o use static when we are using the multiple dynamic libraries
@mgautierfr mgautierfr merged commit a9f37d4 into main Aug 25, 2023
2 checks passed
@mgautierfr mgautierfr deleted the Issue#51 branch August 25, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants