Skip to content
This repository has been archived by the owner on Aug 13, 2022. It is now read-only.

Added new library to handle fundamentals api. #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

willthiswork89
Copy link

This start focused on the Earnings and overview API calls which are arguably the most important ones. More to come.

@ghost
Copy link

ghost commented Feb 20, 2021

@willthiswork89 thank you for your contribution. Appreciate your help!

A few things to improve before I'll be able to include it in the next version:

  1. Classes EarningsBase, EarningsParserBase, EarningsPeriodBase, OverviewBase, OverviewParserBase could be moved to AlphaVantage.Net.Fundamentals project, because they are not going to be used across other projects
  2. Please add unit tests for FundamentalsClient. For that, you need to create AlphaVantage.Net.Fundamentals.Tests project under ./tests folder
  3. Also worth to add demo in AlphaVantage.Net.Demo project and add corresponding section in README.md

@ghost
Copy link

ghost commented Feb 22, 2021

@willthiswork89 also please add yourself as an author of the new AlphaVantage.Net.Fundamentals nuget package (in csproj file)

This was referenced Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant