forked from kubernetes/enhancements
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal review #27
Open
rata
wants to merge
10
commits into
master
Choose a base branch
from
rata/userns
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
internal review #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
reviewed
Feb 1, 2023
rata
force-pushed
the
rata/userns
branch
9 times, most recently
from
February 7, 2023 16:17
734207a
to
a61d587
Compare
rata
changed the base branch from
master
to
dependabot/go_modules/github.com/go-playground/validator/v10-10.12.0
January 11, 2024 16:08
rata
changed the base branch from
dependabot/go_modules/github.com/go-playground/validator/v10-10.12.0
to
master
January 11, 2024 16:08
giuseppe
reviewed
Jan 11, 2024
mrunalp
reviewed
Jan 16, 2024
rata
force-pushed
the
rata/userns
branch
6 times, most recently
from
January 18, 2024 11:11
cca967f
to
0a9ec5c
Compare
Signed-off-by: Rodrigo Campos <[email protected]>
Signed-off-by: Rodrigo Campos <[email protected]>
Signed-off-by: Rodrigo Campos <[email protected]> Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Rodrigo Campos <[email protected]>
So it is rendered properly on github. Signed-off-by: Rodrigo Campos <[email protected]>
Signed-off-by: Rodrigo Campos <[email protected]>
giuseppe
force-pushed
the
rata/userns
branch
3 times, most recently
from
January 26, 2024 14:46
91377aa
to
d7e437c
Compare
Signed-off-by: Rodrigo Campos <[email protected]> Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
Co-authored-by: Giuseppe Scrivano <[email protected]> Signed-off-by: Giuseppe Scrivano <[email protected]> Signed-off-by: Rodrigo Campos <[email protected]>
Signed-off-by: Rodrigo Campos <[email protected]> Signed-off-by: Peter Hunt <[email protected]>
haircommander
force-pushed
the
rata/userns
branch
from
February 8, 2024 18:32
f688ef1
to
b64d85b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @giuseppe
Reviewing commit by commit, or just reading the end file might be simpler than the diff