add ManifestStaticInterface

src/plugin/packer/contents-zip/index.ts

@@ -1,4 +1,4 @@
-import type { ManifestInterface } from "../manifest";
+import type { ManifestInterface, ManifestStaticInterface } from "../manifest";
 import { ManifestV1 } from "../manifest";
 import { ZipFile } from "../zip";
 import streamBuffers from "stream-buffers";
@@ -40,24 +40,7 @@ export class ContentsZip extends ZipFile implements ContentsZipInterface {
     path: string;
     manifest: ManifestV1;
   }> {
-    const fileLists = await this.fileList();
-    const entries = await this.entries();
-    const manifestList = fileLists.filter(
-      (file) => path.basename(file) === "manifest.json",
-    );
-    if (manifestList.length === 0) {
-      throw new Error("The zip file has no manifest.json");
-    } else if (manifestList.length > 1) {
-      throw new Error("The zip file has many manifest.json files");
-    }
-    const manifestPath = manifestList[0];
-    const manifestEntry = entries.get(manifestPath);
-    if (manifestEntry === undefined) {
-      throw new Error("Failed to find manifest.json from the zip file");
-    }
-    const manifestJson = await this.getFileAsString(manifestPath);
-    const manifest = ManifestV1.parseJson(manifestJson);
-    return { path: manifestPath, manifest };
+    return extractManifestFromContentsZip(this, ManifestV1);
   }
 }
 
@@ -83,3 +66,27 @@ const createContentsZip = async (
   debug(`plugin.zip: ${size} bytes`);
   return output.getContents() as any;
 };
+
+const extractManifestFromContentsZip = async (
+  contentsZip: ContentsZipInterface,
+  Manifest: ManifestStaticInterface,
+) => {
+  const fileLists = await contentsZip.fileList();
+  const entries = await contentsZip.entries();
+  const manifestList = fileLists.filter(
+    (file) => path.basename(file) === "manifest.json",
+  );
+  if (manifestList.length === 0) {
+    throw new Error("The zip file has no manifest.json");
+  } else if (manifestList.length > 1) {
+    throw new Error("The zip file has many manifest.json files");
+  }
+  const manifestPath = manifestList[0];
+  const manifestEntry = entries.get(manifestPath);
+  if (manifestEntry === undefined) {
+    throw new Error("Failed to find manifest.json from the zip file");
+  }
+  const manifestJson = await contentsZip.getFileAsString(manifestPath);
+  const manifest = Manifest.parseJson(manifestJson);
+  return { path: manifestPath, manifest };
+};

src/plugin/packer/contents-zip/zip.ts

@@ -10,6 +10,9 @@ import { finished } from "node:stream/promises";
 import type { ContentsZipInterface } from "./index";
 import type { Entries } from "../zip";
 
+// rezip() has been only used in web version plugin packer.
+// We are keeping this function to support a web version in the future.
+
 /**
  * Extract and rezip contents.zip
  */

src/plugin/packer/manifest/index.ts

@@ -5,6 +5,11 @@ import fs from "fs";
 
 const debug = _debug("manifest");
 
+export interface ManifestStaticInterface {
+  parseJson(manifestJson: string): ManifestInterface;
+  loadJsonFile(jsonFilePath: string): Promise<ManifestInterface>;
+}
+
 export interface ManifestInterface {
   validate(options?: ValidatorOptions): ReturnType<typeof validate>;
   sourceList(): string[];
@@ -40,6 +45,8 @@ export class ManifestV1 implements ManifestInterface {
   }
 }
 
+const _ = ManifestV1 satisfies ManifestStaticInterface;
+
 // TODO: These types must be exported from kintone/plugin-manifest-validator
 type ValidatorOptions = {
   relativePath?: (filePath: string) => boolean;