Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INF-1923] add check for already defined constant #52

Merged
merged 2 commits into from
May 15, 2024

Conversation

katjacresanti
Copy link
Contributor

@katjacresanti katjacresanti commented May 14, 2024

This change adds a check for whether or not ReplicaPools(class_name) is already defined before setting it again to mitigate warning messages in the sidekiq stderr logs:

warning: already initialized constant ReplicaPools::Admin1

Also bumps the minor release version to 2.6.7.

@katjacresanti katjacresanti self-assigned this May 14, 2024
Copy link
Member

@talaris talaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should bump the version number as well to prep for release.

@katjacresanti katjacresanti merged commit 9673ab9 into main May 15, 2024
8 checks passed
@katjacresanti katjacresanti deleted the address-already-initialized-constant-errors branch May 15, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants