Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1547] Encapsulate Late Pledge Apple Pay Logic #2088

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

scottkicks
Copy link
Contributor

@scottkicks scottkicks commented Jun 25, 2024

📲 What

Creates a new ApplePayCheckoutService to encapsulate late pledge Apple Pay Logic.

🤔 Why

Encapsulating checkout View Model dependencies that are shared across checkout to hopefully make consolidating late pledges and crowdfunding, and adding a new View Model for Pledge Redemption, easier and more maintainable.

This logic is used in crowdfunding and late pledges, but for now, we're just encapsulating it in the late pledge flow.

Ideally, this gets shared in the crowdfunding VM, but the way ApplePay is being used in that flow there are a lot of differences, so I think that should be done separately.

🛠 How

Creates a new ApplePayCheckoutService and updates PostCampaignCheckoutViewModel to use it.

👀 See

No visible changes

✅ Acceptance criteria

  • No changes to late pledge flow via ApplePay pledges
  • Make a note to test ApplePay late pledges in the next TestFlight build on Prod.

@scottkicks scottkicks self-assigned this Jun 25, 2024
@scottkicks scottkicks marked this pull request as ready for review July 2, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant