Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2 new cvars to enable C4 and enable all skins. #271

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rogeraabbccdd
Copy link

  • Added new cvar sm_weapons_enable_c4 to enable skins on C4.
  • Added new cvar sm_weapons_enable_all_skins to enable all skins on all weapons.

@rogeraabbccdd rogeraabbccdd changed the title Added 2 new cvars Added 2 new cvars to enable C4 and enable all skins. Mar 26, 2023
@penalte
Copy link

penalte commented Apr 6, 2023

Translation error.

@crashzk
Copy link
Contributor

crashzk commented Apr 8, 2023

@rogeraabbccdd

L 04/07/2023 - 21:19:53: [SM] Exception reported: Language phrase "weapon_c4" not found (arg 5)

L 04/07/2023 - 21:19:53: [SM] Blaming: weapons.smx

L 04/07/2023 - 21:19:53: [SM] Call stack trace:

L 04/07/2023 - 21:19:53: [SM]   [0] Menu.SetTitle

L 04/07/2023 - 21:19:53: [SM]   [1] Line 65, weapons\config.sp::ReadConfig

L 04/07/2023 - 21:19:53: [SM]   [2] Line 66, weapons\forwards.sp::OnConfigsExecuted

[EDIT]
Fix translations en: weapons.phrases.txt

@rogeraabbccdd
Copy link
Author

rogeraabbccdd commented Apr 8, 2023

Added all skins menu for each weapon when sm_weapons_enable_all_skins is enabled.

20230408152548_1
20230408152552_1

@crashzk
Copy link
Contributor

crashzk commented Apr 10, 2023

@rogeraabbccdd just a feedback, so far everything is going well with this change.

I would also like to know if you could take a look at this suggestion (Live StatTrak(tm) Update): #177

Would it be possible to carry out the implementation together with this PR, or do you believe that it would be a lot of modifications and with that a separate PR? And of course, if you could do that.

@emrahkaraduman
Copy link

emrahkaraduman commented May 28, 2023

while trying to compile i have warnings and it gives me error logs. Which sourcemod compiler version did you use while coding?
Error log L 05/28/2023 - 17:30:34: [SM] Warning: plugin weapons.smx is using more than 100000 handles!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants