Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for prefixing resources #351

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Semper-Viventem
Copy link

In my working project, there was a problem building fat-aar: the library depends on 30 modules, which have about 60,000 resources, and all of them were bundled into the library. Since the main project also depends on these resources, it makes no sense to rename them, and they cause conflicts in the SDK client. The standard build plugin does not support prefixing resources. This PR adds such an opportunity.

Usage:

fataar {
    resourcePrefix = "lib_name_"
}

@Semper-Viventem
Copy link
Author

@JeroenMols It might be interesting for you

@kezong
Copy link
Owner

kezong commented Nov 8, 2021

Thank you for your PR. It's a great job.
I'll take the time to review it.

@s-ilnar
Copy link

s-ilnar commented Nov 12, 2021

It would be very helpful! I also need this)

@Semper-Viventem
Copy link
Author

Hello @kezong. Sorry for the follow-up. Did you manage to review the pull request?

@kezong
Copy link
Owner

kezong commented Dec 3, 2021

@Semper-Viventem Sorry, there are too many changes. In my project, which have 80+ modules, the change did not take effect, and a compilation error occurred.
At present, I don't have much time to check the problems, so I can't merge it.

This function seems to be relatively independent. I think it can be an independent plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants