Seperate out unmatched from generic SM platform somewhat #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nanamiiiii could you take a look at this patch? I believe it should work, but unfortunately don't have access to a hifive unmatched board right now to test it. |
grg-haas
force-pushed
the
bugfix/unmatched-sm-plat
branch
from
bbe79cb
to
025a236
Compare
|
@grg-haas Sorry. I just noticed your mention. |
|
If you could, that would be great! I landed a version of this as part of the CVA6 support a week or so back, so you should be able to try the latest master with KEYSTONE_PLATFORM=hifive_unmatched -- I'm pretty sure it should work but sadly don't have the hardware to test it myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling the SM for
generic. I noticed recently that theunmatchedplatform files are also included in the build. While this is mostly harmless at runtime (besides increasing the binary size of the SM somewhat), it does sometimes lead to unnecessary and unrelated compilation failures when only attempting to work with thegenericplatform. This PR separates out theunmatchedSM platform a bit more, leveraging the insight that we (again) only added a small patch tofu740.cwhich callssm_initat the appropriate time. We can accomplish the same thing without copying a source file by#include-ingfu740.cand adding a small platform wrapper around it.