feat(developer): kvk support 🙀 #7355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #7238. Supports reading and writing .kvk files, and reading .kvks files, to/from an in-memory VisualKeyboard object. TODO: - Full validation of .kvks files - Writing .kvks files - Some cleanup of API surfaces for consistency
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
Also minor tweaks around reading .xml files.
Now has a shared object for all tests, reset between tests, and if the test fails, prints any reported compiler messages. Also updates kvk and kvks tests with refactored names from previous commit.
srl295
reviewed
Sep 26, 2022
srl295
approved these changes
Sep 27, 2022
| constructor() { | ||
| // | ||
| // Binary restructure definitions matching VisualKeyboardSaverBinary.pas | ||
| // TODO: move binaries to separate kvk-file.ts |
mcdurdin
commented
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7238.
Supports reading and writing .kvk files, and reading .kvks files, to/from an in-memory VisualKeyboard object.
TODO:
Writing .kvks files--> tracking in feat(common): write kvks file from Typescript 🙀 #7379@keymanapp-test-bot skip