-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ldml_test] add experimental/sil/ldml_test #2865
base: master
Are you sure you want to change the base?
Conversation
- test out LDML keyboards in repo - keymanapp/keyman#10505
The convention for the keyboards repository is to store the keyboard in a folder based on the first letter or prefix, so: Following that convention, I'd expect |
The main point was to test ldml. I expected there may be updates needed for local conventions. Would sil_ldml_test make sense? I can rename it. |
sil/sil_ldml_test would fit the pattern. Is this intended to be an example? If so, sil_ldml_example maybe? The concern is that current policy is to not change keyboard folder/project names once they've been created. |
It's more of a test than an example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could consider marking this keyboard as deprecated just to avoid it coming up for end users in the keyboard search?
As @DavidLRowe noted, it needs to be called either experimental/sil/sil_ldml_test or experimental/l/ldml_test.
Looking good though. Seems to be putting CI through its paces
<Name URL="">LDML Test</Name> | ||
<Copyright URL="">Copyright © Steven R. Loomis</Copyright> | ||
<Author URL="">Steven R. Loomis</Author> | ||
<Description URL="">Test Keyboard</Description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is inadequate detail because this is what will show in the keyboard details on keyman.com. We need this to be clear for end users who encounter it on keyman.com.
Test Keyboard for LDML | ||
|
||
|
||
Trying it Out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this information would be better placed in welcome.htm -- then it is available when the keyboard is installed, and not just in the source.
/build | ||
/*.kpj.user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should not be needed as both of these are in the root-level .gitignore
From the build log:
|
I like the deprecated idea. Will update this. |
How do we mark it deprecated? |
The usual way this is done is for a keyboard to mark another keyboard as deprecated. In Keyman Developer (v17+) this can be done in the Packaging section, Details tab: @mcdurdin Is is possible for a package to deprecate itself? |
Still got some changes requested (plus this is in draft, so not clear if you intended to ask for review?)
I don't know! It'd be weird, and could have other side-effects, so I don't think I'm keen on doing that. So... despite my brilliant idea, I don't think we can go this way for now. That is a weakness in the package-deprecation pattern, but it's not an easy one to solve without repetition of data... (DEPRECATED.md is informative only at this point, but we could test for its as a possibility?) Would add complexity to the keyboards build. |
|
Yes apologies I missed the remaining items
Edit it won't let me rescind the request :)
|
I think we can probably close this as redundant given #2993 is a real LDML keyboard, so I think we don't need a test keyboard in the keyboards repo. |
same as #2864 but in same repo
Fixes: #2484.