-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ipachart] 0.2 initial public test release #2845
base: master
Are you sure you want to change the base?
Conversation
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
There is a touch layout for the For this keyboard, it looks like you may have started with your naijatype files and manually edited them? You'll need to clean up all references to folders, etc for naijatype. I saw some in your .kps file. |
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
Oops. Yes, I think that's left over from 4 years ago when I started it. Thanks for spotting it. It was just the Package because the IPA chart itself I started from a template. sil_ipa is based on a QWERTY keyboard and this keyboard is based on the IPA chart. |
We'd like to address that issue #2213 |
<OSKFont>Andika-Regular.ttf</OSKFont> | ||
<DisplayFont>Andika-Regular.ttf</DisplayFont> | ||
<Languages> | ||
<Language ID="zzz">IPA</Language> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should use the same language ID as sil_ipa
<Language ID="und-Latn">und-Latn</Language> |
but depends on keymanapp/keyman#11046 gets resolved.
Can these files be removed?
|
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
Yes. Done. The ipachart_code_generator is useful for generating some of the CSS and KMN code, but I'll keep it in a private repo. |
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
Hmm, I would be happy for the .ods file to remain, even though it is binary. Good for future maintainers. |
Some feedback:
You may, if you want to, include these two files:
Our practice has generally been to create an |
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
Currently this keyboard seems to be targeting mobile only. The "Supported Platforms" section of the README.md should change accordingly, along with the "&TARGETS" store in the .kmn file, which could be 'tablet phone' (or perhaps 'tablet phone web') rather than 'any'. In the past there have been complaints about a "mobile only" keyboard ceasing to work when an external keyboard was plugged in. It would be helpful if your documentation indicates that the keyboard won't work with an external keyboard attached to the device. (Or else, add a desktop keyboard, of course!) There are compiler warnings indicating that these two lines will never be used, since the keystroke (between the "+" and the ">") doesn't correspond to a keyboard key: There's also a warning that flick or multi-tap gestures need version 17 of the compiler (that is, a |
Thanks for all the observations and help. Yes it’s just targeting mobile. The existing sil ipa one does desktop keyboards well enough I think. And there’s IPAtotal for another perspective. But I hadn’t found an ipa Chart arrangement except Moses Hall’s IPA palette for macOS.
David (in Nigeria)
… On 3 Jul 2024, at 00:16, DavidLRowe ***@***.***> wrote:
Currently this keyboard seems to be targeting mobile only. The "Supported Platforms" section of the README.md should change accordingly, along with the "&TARGETS" store in the .kmn file, which could be 'tablet phone' (or perhaps 'tablet phone web') rather than 'any'.
In the past there have been complaints about a "mobile only" keyboard ceasing to work when an external keyboard was plugged in. It would be helpful if your documentation indicates that the keyboard won't work with an external keyboard attached to the device. (Or else, add a desktop keyboard, of course!)
There are compiler warnings indicating that these two lines will never be used, since the keystroke (between the "+" and the ">") doesn't correspond to a keyboard key:
't' + 'ʃ' > 't͡ʃ'
'd' + 'ʒ' > 'd͡ʒ'
There's also a warning that flick or multi-tap gestures need version 17 of the compiler (that is, a
store(&Version) "17.0"
statement in the .kmn file.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
@rowbory No pressure! Just wanting to make sure that you're not waiting on anything from us. |
Has anyone tried making a touch IPA chart before?