Add focus support to ColormapOverlay #1434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evy Bongers <[email protected]>
EvyBongers
commented
Jul 12, 2024
| @@ -73,6 +74,10 @@ EventHandlerResult ColormapOverlay::beforeSyncingLeds() { | |||
| return EventHandlerResult::OK; | |||
| } | |||
|
|
|||
| EventHandlerResult ColormapOverlay::onFocusEvent(const char *input) { | |||
| return ::LEDPaletteTheme.themeFocusEvent(input, PSTR("colormap.overlay"), map_base_, no_themes_); | |||
There was a problem hiding this comment.
colormap.overlay seems like the most logical focus command to me. Let me know what you think.
|
@EvyBongers did you end up testing this on hardware? |
|
I completely forgot about this. I'll see about testing it today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick attempt to implement focus support in ColormapOverlay. I feel this should work, but I don't have my keyboard with me right now, so any debugging I'll have to do later.