Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable IPv4 forwarding at rooter startup #2429

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

seanthegeek
Copy link
Contributor

Also add the --sysctrl option to the rooter.py CLI

Also add the `--sysctrl` option to the `rooter.py` CLI
@seanthegeek seanthegeek marked this pull request as ready for review December 19, 2024 16:33
@doomedraven
Copy link
Collaborator

qq, why do you write 0? with just run command it should be more than enough right?

@seanthegeek
Copy link
Contributor Author

I'm guessing you meant 1 instead of zero. I thought the same thing, but the documentation says to do both, so I'm following the documentation.

https://capev2.readthedocs.io/en/latest/installation/host/routing.html

$ echo 1 | sudo tee -a /proc/sys/net/ipv4/ip_forward
$ sudo sysctl -w net.ipv4.ip_forward=1

It's also weird that the documentation is using tee -a to append to the file. We probably don't need that at all. I'll do some tests.

The CAPE [documentation](https://capev2.readthedocs.io/en/latest/installation/host/routing.html) says to run

```bash
echo 1 | sudo tee -a /proc/sys/net/ipv4/ip_forward
sudo sysctl -w net.ipv4.ip_forward=1
```

But only the `sysctl` command is needed.
@seanthegeek
Copy link
Contributor Author

Yep, only the sysctl command is needed. I removed the file edit from the PR.

@doomedraven doomedraven merged commit 34c4be4 into kevoreilly:master Dec 20, 2024
3 checks passed
@doomedraven
Copy link
Collaborator

thanks for PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants