Ensure body is consumed only once (alternative to #851) #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sathieu
force-pushed
the
consume-body-once
branch
from
aa91203
to
9b0e9d9
Compare
|
@hartwork Please take a look at this PR 🙏 . |
|
@sathieu I had a quick look and I think understand the problem now but from a quick look the patch raises questions, may not be the best place to patch yet, and is also lacking a new test to both document and regression-protect the case that it's fixing. I have other priorities at the moment, I won't be able to help more at the moment, thanks for your understanding. |
hartwork
requested changes
Jun 30, 2024
sathieu
force-pushed
the
consume-body-once
branch
from
9b0e9d9
to
f7f144f
Compare
Fixes: kevin1024#846 Signed-off-by: Mathieu Parent <[email protected]>
sathieu
force-pushed
the
consume-body-once
branch
from
f7f144f
to
e0db062
Compare
|
Thanks @hartwork I've fixed CI and added tests. Back to you 🏓 ! |
hartwork
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #846