Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workflow] Download bpf objects for veristat from S3 bucket #232

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

yurinnick
Copy link
Contributor

Use bpf objects from S3 bucker for Veristat validation and comparison

@yurinnick yurinnick marked this pull request as draft August 4, 2023 23:43
@yurinnick yurinnick temporarily deployed to aws-openid-auth August 4, 2023 23:57 — with GitHub Actions Inactive
@yurinnick yurinnick temporarily deployed to aws-openid-auth August 5, 2023 05:16 — with GitHub Actions Inactive
@yurinnick yurinnick temporarily deployed to aws-openid-auth August 8, 2023 19:56 — with GitHub Actions Inactive
@yurinnick yurinnick force-pushed the veristat-bpf-objects branch from 88b1030 to a068c93 Compare August 9, 2023 18:20
@yurinnick yurinnick force-pushed the veristat-bpf-objects branch 25 times, most recently from c18d054 to bcf9b9d Compare August 29, 2023 23:15
@yurinnick yurinnick force-pushed the veristat-bpf-objects branch 5 times, most recently from 69b77dd to 244e171 Compare August 30, 2023 00:09
@yurinnick yurinnick marked this pull request as ready for review August 30, 2023 00:41
@yurinnick yurinnick force-pushed the veristat-bpf-objects branch from 244e171 to 658efad Compare August 30, 2023 19:44
Copy link
Contributor

@chantra chantra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would like to sort out the impliciteness of running run_veristat_kernel though.

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@@ -27,6 +28,21 @@ read_lists() {
done) | cut -d'#' -f1 | sed -e 's/^[[:space:]]*//' -e 's/[[:space:]]*$//' | tr -s '\n' ','
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WE should get rid of this now that https://lore.kernel.org/bpf/[email protected]/ is implemented.

I am not sure it would take multiple files, but -a @<(cat "$BPF_SELFTESTS_DIR/ALLOWLIST" "$BPF_SELFTESTS_DIR/ALLOWLIST.${ARCH}" "$VMTEST_CONFIGS_PATH/ALLOWLIST" "$VMTEST_CONFIGS_PATH/ALLOWLIST.${ARCH}") should work

ci/vmtest/run_selftests.sh Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/actions/veristat_baseline_compare/action.yml Outdated Show resolved Hide resolved
.github/actions/veristat_baseline_compare/action.yml Outdated Show resolved Hide resolved
@yurinnick yurinnick force-pushed the veristat-bpf-objects branch 3 times, most recently from c759e5b to f85f77f Compare September 11, 2023 21:08
Use bpf objects from S3 bucker for Veristat validation and comparison

Signed-off-by: Nikolay Yurin <[email protected]>
Copy link
Contributor

@chantra chantra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for the tests to run to make sure everything is still working as expected.

@yurinnick yurinnick merged commit 40d8fca into master Sep 12, 2023
20 of 30 checks passed
@yurinnick yurinnick deleted the veristat-bpf-objects branch September 12, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants