-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workflow] Download bpf objects for veristat from S3 bucket #232
Conversation
88b1030
to
a068c93
Compare
c18d054
to
bcf9b9d
Compare
69b77dd
to
244e171
Compare
244e171
to
658efad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I would like to sort out the impliciteness of running run_veristat_kernel though.
@@ -27,6 +28,21 @@ read_lists() { | |||
done) | cut -d'#' -f1 | sed -e 's/^[[:space:]]*//' -e 's/[[:space:]]*$//' | tr -s '\n' ',' | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WE should get rid of this now that https://lore.kernel.org/bpf/[email protected]/ is implemented.
I am not sure it would take multiple files, but -a @<(cat "$BPF_SELFTESTS_DIR/ALLOWLIST" "$BPF_SELFTESTS_DIR/ALLOWLIST.${ARCH}" "$VMTEST_CONFIGS_PATH/ALLOWLIST" "$VMTEST_CONFIGS_PATH/ALLOWLIST.${ARCH}")
should work
c759e5b
to
f85f77f
Compare
Use bpf objects from S3 bucker for Veristat validation and comparison Signed-off-by: Nikolay Yurin <[email protected]>
f85f77f
to
b1eb21e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's wait for the tests to run to make sure everything is still working as expected.
Use bpf objects from S3 bucker for Veristat validation and comparison