add BPF GCC support for BPF CI #7737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chantra
reviewed
Sep 16, 2024
There was a problem hiding this comment.
Overall, LGTM. Did not do a throughout review, but just dropping a few comment regarding the failed set_matrix step.
Also, please do this PR against https://github.com/kernel-patches/vmtest/ instead. kernel-patches/bpf pulls the kernel from upstream and then copies kernel-patches/vmtest into it.
.github/scripts/matrix.py
Outdated
| @@ -64,6 +71,7 @@ def to_dict(self) -> Dict[str, Union[str, int]]: | |||
| class BuildConfig: | |||
| arch: Arch | |||
| toolchain: Toolchain | |||
| bpf_toolchain: Toolchain = Toolchain(compiler=Compiler.LLVM, version=DEFAULT_LLVM_VERSION) | |||
There was a problem hiding this comment.
this is what seems to cause the set_matrix step failure.
The error is:
Traceback (most recent call last):
File "/tmp/work/bpf/bpf/.github/scripts/matrix.py", line 70, in <module>
@dataclasses.dataclass
^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/dataclasses.py", line 1268, in dataclass
return wrap(cls)
^^^^^^^^^
File "/usr/lib/python3.12/dataclasses.py", line 12[5](https://github.com/kernel-patches/bpf/actions/runs/10881506538/job/30190585441?pr=7737#step:3:6)8, in wrap
return _process_class(cls, init, repr, eq, order, unsafe_hash,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/dataclasses.py", line 994, in _process_class
cls_fields.append(_get_field(cls, name, type, kw_only))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/dataclasses.py", line [8](https://github.com/kernel-patches/bpf/actions/runs/10881506538/job/30190585441?pr=7737#step:3:9)52, in _get_field
raise ValueError(f'mutable default {type(f.default)} for field '
ValueError: mutable default <class '__main__.Toolchain'> for field bpf_toolchain is not allowed: use default_factory
From https://stackoverflow.com/a/75677129
it seems https://gist.github.com/chantra/b4ac937f0f0e909d238bb03f7aacae49 would work.
Signed-off-by: Cupertino Miranda <[email protected]>
cupermir
force-pushed
the
bpf-next_base
branch
from
01cef01 to
78a307f
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
6 times, most recently
from
e1cb77d to
6b1e4f8
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
8 times, most recently
from
866313b to
757fcea
Compare
|
Automatically cleaning up stale PR; feel free to reopen if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests enables BPF GCC compilation testing for the CI.
Required changes in libbpf/ci where pull requested in libbpf/ci#144