Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the Alacritty themes #79

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updated the Alacritty themes #79

wants to merge 2 commits into from

Conversation

4l1fe
Copy link

@4l1fe 4l1fe commented Jul 6, 2024

Issue

The current config format yaml is outdated for Alacritty.

I slightly changed themes due to the Alacritty's warnings

[1306.381547959s] [WARN ] [alacritty] YAML config "/home/kvdm/.config/alacritty/themes/themes/flexoki-light.yaml" is deprecated, please migrate to TOML using `alacritty migrate`
[1306.382397785s] [WARN ] [alacritty_config_derive] Unused config key: bright_background
[1306.382428994s] [WARN ] [alacritty_config_derive] Unused config key: dim_background

Changes

  • Both theme configs are renamed
  • The configs are converted with alacritty migrate -c ~/.config/alacritty/themes/themes/flexoki-dark.yaml
  • The keys bright_background, dim_background are dropped
  • Changes are tested and works fine
    image

@kepano
Copy link
Owner

kepano commented Jul 7, 2024

Thanks! Would it make make sense to keep the YAML files for older versions of Alacritty?

@oahshtsua
Copy link

Yes. Please keep the YAML files alongside the new TOML files since some distributions still seem to have versions of alacritty that don't yet support the TOML configuration (PopOS comes to mind).

Copy link
Owner

@kepano kepano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the .yaml versions available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants