Skip to content
This repository has been archived by the owner on Mar 31, 2024. It is now read-only.

Implement --dont-skip #8

Closed
wants to merge 14 commits into from
Closed

Conversation

WaylonWalker
Copy link

@WaylonWalker WaylonWalker commented Sep 19, 2019

I attemtped to implement --force, but I am getting the following error. I assume that it it something that is currently in flux. I removed any of my code that did anything and it was still there.

 + Skipping install/python.
 + Executing install:
 |  /dev/fd/62: line 14: syntax error: unexpected end of file
 |  /dev/fd/63: line 15: syntax error: unexpected end of file
Task install failed!

If it is easier to implement yourself, no hard feelings.

EDIT

This is to solve issue #7

@kennethreitz
Copy link
Owner

how is this different than --yes?

@WaylonWalker
Copy link
Author

WaylonWalker commented Sep 19, 2019

force will force the task to run even if skip triggers.

  --yes                    Set medium–security prompts to yes.
  --force -f              Forces task to run even if skip key hasnt changed

bakeforce

@WaylonWalker
Copy link
Author

Switched it up based on your comment on the issue

  --yes                    Set medium–security prompts to yes.
  --dont-skip          Forces task to run even if skip key hasnt changed

bakedontskip

@kennethreitz
Copy link
Owner

Let me get CI working :)

@kennethreitz kennethreitz changed the title Implement --force Implement --dont-skip Sep 19, 2019
@kennethreitz kennethreitz reopened this Sep 19, 2019
@kennethreitz
Copy link
Owner

rebase?

@WaylonWalker
Copy link
Author

Had some time to read through the tests and understand what was broken. Tests are now passing, Please let me know if there are any other changes I can make.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants