Allow customizing labels #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'Label' sets the folder/file/size labels and 'Hide0Label' allows hiding them completely when 0 folders/files
...into separate rows for clarity
Escape meta-characters * ? [ ] by [bracketing them] Fixes: kek91#22
… hidden For some reason you need to call the core.commands functions instead of their copies otherwise the setting the filter on launch wasn't recognized by them and resulted in a ValueError
|
Thanks! Don't have time at the moment, but will check it out later tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Think this is the last config option I wanted to add — for the labels themselves
Also finally fixed that nasty
ValueErrorbug! Don't understand why, but importing and calling thecore.commandsfunctions directly seemed to do the trick (alternative that worked: copy one more command InitHiddenFilesFilter from Core and call it ourselves, but that would require disabling it in the Core (last time I tried it without disabling the Core command the pane wouldn't show any files at all as the filters seemed to just duplicate)there might be something in the closed source
pane._remove_filterthat leads to this or maybe just some general object thingy I don't get, but anyway, but glad it's sorted out ✨✨! (even though we need to use a private Core function)FYI: since each bug fix is structured as a minor version bump, don't forget to make 4 tags/releases as well if you want the links to work correctly
v0.4.4 — 15.08.2021
HideDotfilenow also affects the pane list, not just the status barv0.4.3 — 14.08.2021
ValueErroron the firstToggle hidden filesif a pane is launched with hidden files hiddenv0.4.2 — 14.08.2021
[]*?in paths (e.g.[A--_B]) crash glob or lead to wrong resultsv0.4.1 — 13.08.2021
✨ User-configurable options for the Folder/File/Size labels
Dirs:Files:Size:Folder/File/SizelabelsTrue