Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds optional callback method (logger) for Observable.log/spy() #315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

unematiii
Copy link

@unematiii unematiii commented May 12, 2021

I have a use-case where I would like to log/spy using function other than console.log and I don't want to override the log method on console. This PR should make this possible.

(Ofc, it is possible to simply wrap the observer and build the desired functionality yourself, but it would be more convenient, if this option comes from library itself.)

PS. Looks like CI pipelines for Node 6/8 are broken.

@bpinto
Copy link
Contributor

bpinto commented Aug 15, 2021

I personally like this change. On #318 I'm proposing we drop support for node 6 and 8 (and maybe 10) which means tests would pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants