Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate observables are unsubscribed #412

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Validate observables are unsubscribed #412

wants to merge 6 commits into from

Commits on Nov 28, 2021

  1. [email protected]

    @bpinto
    bpinto committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    a19524a View commit details
    Browse the repository at this point in the history

  2. Replace lolex imports with @sinonsjs/fake-timers

    @bpinto
    bpinto committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    fd0a341 View commit details
    Browse the repository at this point in the history

  3. Update watchWithTime usage 

    Prettier is formatting the line as:

```js
;({log, unwatch} = watchWithTime(received))
```

so we are disabling prettier formatting for now.
    @bpinto
    bpinto committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    1b2f1fa View commit details
    Browse the repository at this point in the history

  4. a-Z

    @bpinto
    bpinto committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    199a7e6 View commit details
    Browse the repository at this point in the history

  5. Validate observables are unsubscribed during tests

    @bpinto
    bpinto committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    96e5ddd View commit details
    Browse the repository at this point in the history

  6. Always unwatch observable checked with toEmitInTime

    @bpinto
    bpinto committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    f5d4d7a View commit details
    Browse the repository at this point in the history