Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure github actions for CI #396

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Configure github actions for CI #396

merged 2 commits into from
Nov 24, 2021

Conversation

bpinto
Copy link
Contributor

@bpinto bpinto commented Nov 17, 2021

There is no better way other than this to start working on this repository, right? 😀

@bpinto
Copy link
Contributor Author

bpinto commented Nov 20, 2021

@mAAdhaTTah I intend to start with this repository, what do you think? I was thinking after we get all PRs (dependabot) merged on kefir-test-utils we could maybe release a new major there so that I can use it here?

@bpinto
Copy link
Contributor Author

bpinto commented Nov 24, 2021

@mAAdhaTTah now that our work on kefir-test-utils is complete (we still need a version release there but that can happen later), what do you think about this?

I'd like to start updating all the old libraries after this. Is there a feature you would like to be added to this project?

@mAAdhaTTah
Copy link
Contributor

I don't think there are any new features or breaking changes required for this major bump. There is a request for a new matcher in #86 but the OP didn't respond and I don't want to add API surface area without a clear use case, plus it's not breaking, so we don't need it for this major version bump.

@mAAdhaTTah mAAdhaTTah merged commit b811b60 into kefirjs:master Nov 24, 2021
@bpinto
Copy link
Contributor Author

bpinto commented Nov 24, 2021

What do you do with stale issues? Have you considered closing it?

@mAAdhaTTah
Copy link
Contributor

Yeah, I usually do, but I haven't been maintaining these test utils as actively lately so leaving it open wasn't a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants