-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhance PagerDuty provider: fetch historical incidents & expand metadata #1267
feat: Enhance PagerDuty provider: fetch historical incidents & expand metadata #1267
Conversation
@onyedikachi-david is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask you to add a unittest for _format_alert make it easier for us to debug?
…nyedikachi-david/keep into feature/pagerduty-historical-incidents
@Matvey-Kuk GM, I don't know if you have found time to review the added test. |
Closing due to #1262 (comment) |
/claim #1262
Closes #1262
📑 Description
This PR enhances the PagerDuty provider to fetch historical incidents and expand the metadata retrieved for each incident. Key changes include:
_get_alerts
method to retrieve incidents from the past 30 days, with pagination support for up to 1000 incidents.include[]
parameter to the PagerDuty API request to fetch additional incident details._format_alert
method to process and include comprehensive metadata such as acknowledgers, first trigger log entries, and conference bridge information.DEFAULT_LOOKBACK_DAYS
,MAX_INCIDENTS
, andINCLUDE_DETAILS
class attributes for easy configuration.✅ Checks
ℹ Additional Information