-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pretty printing catalog #3990
base: main
Are you sure you want to change the base?
Pretty printing catalog #3990
Conversation
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
…-pretty-printing-catalog
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
…-pretty-printing-catalog
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
…-pretty-printing-catalog
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
…-pretty-printing-catalog
Petty thing 🙏🏼 But could you attach screenshots of how this looks on VS Code notebooks, Jupyter Notebook 7.0+, and IPython? |
def _describe(self) -> dict[str, Any]: | ||
return { | ||
"dataset": self._dataset._describe(), | ||
"cache": self._cache._describe(), | ||
"dataset": self._dataset._pretty_repr(self._dataset._describe()), | ||
"cache": self._cache._pretty_repr(self._cache._describe()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not have to update all datasets, that's the only update needed. For the rest, we use the existing implementations of _describe()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_pretty_repr
is already a method of AbstractDataset
. Could you please clarify what you mean by "to the base class instead"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I was under the impression the update need to be propagated to all dataset.
Is the name pretty_repr decided on purpose?
It seems that repr_pretty is something IPython support natively.
https://ipython.readthedocs.io/en/stable/api/generated/IPython.lib.pretty.html
Sure, as soon as #3987 is done |
Signed-off-by: Elena Khaustova <[email protected]>
…-pretty-printing-catalog Signed-off-by: Elena Khaustova <[email protected]>
|
Description
Solves #3981
This PR is done on top of #3987
Development notes
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file