Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic client nature #476

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ compile:
kb-sdk compile $(SPEC_FILE) \
--out $(LIB_DIR) \
--pyclname $(SERVICE_CAPS).$(SERVICE_CAPS)Client \
--dynservver release \
--pyimplname $(SERVICE_CAPS).$(SERVICE_CAPS)Impl;
- rm $(LIB_DIR)/$(SERVICE_CAPS)Server.py

Expand Down
3 changes: 0 additions & 3 deletions kbase.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,3 @@ module-version:

owners:
[gaprice, slebras]

service-config:
dynamic-service: true
8 changes: 3 additions & 5 deletions lib/SampleService/SampleServiceClient.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,15 @@ def __init__(
self, url=None, timeout=30 * 60, user_id=None,
password=None, token=None, ignore_authrc=False,
trust_all_ssl_certificates=False,
auth_svc='https://ci.kbase.us/services/auth/api/legacy/KBase/Sessions/Login',
service_ver='release'):
auth_svc='https://ci.kbase.us/services/auth/api/legacy/KBase/Sessions/Login'):
if url is None:
raise ValueError('A url is required')
self._service_ver = service_ver
self._service_ver = None
self._client = _BaseClient(
url, timeout=timeout, user_id=user_id, password=password,
token=token, ignore_authrc=ignore_authrc,
trust_all_ssl_certificates=trust_all_ssl_certificates,
auth_svc=auth_svc,
lookup_url=True)
auth_svc=auth_svc)

def create_sample(self, params, context=None):
"""
Expand Down