Bulk fns #397
Open
Bulk fns #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 1, 2021 15:05
…using get_sample_address_from_object in get_samples
scanon
reviewed
May 10, 2021
Tianhao-Gu
reviewed
Aug 12, 2021
| 'create_samples', ctx.log_info, as_user=user, skip_check=not as_admin) | ||
| for samp in params['samples']: | ||
| sample, id_, prev_ver = _create_sample_params(samp) | ||
| ret = self._samples.save_sample( |
There was a problem hiding this comment.
I think we could do a try catch here. Then add failed samples to something like failed_addresses?
Tianhao-Gu
reviewed
Aug 12, 2021
| # return variables are: addresses | ||
| #BEGIN create_samples | ||
| if not params.get('samples'): | ||
| raise ValueError(f"") |
There was a problem hiding this comment.
forget to include the actual error message?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.