Cluster the cluster data #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ialarmedalien
commented
Aug 18, 2020
| @@ -43,15 +46,15 @@ def _configure(self): | |||
|
|
|||
| _CLUSTER_BASE = os.path.join(configuration['ROOT_DATA_PATH'], 'cluster_data') | |||
| configuration['_CLUSTER_PATHS'] = { | |||
| 'cluster_I2': os.path.join( | |||
| 'markov_i2': os.path.join( | |||
There was a problem hiding this comment.
rename these to something more informative
ialarmedalien
commented
Aug 18, 2020
|
|
||
| self.check_deltas(edge_data=edge_data, node_metadata=node_metadata, cluster_data=clusters) | ||
|
|
||
| def check_deltas(self, edge_data={}, node_metadata={}, cluster_data={}): |
There was a problem hiding this comment.
brief dataset summary for sanity checking
ialarmedalien
commented
Aug 18, 2020
Comment on lines
+120
to
+122
| for data_structure in [edge_data, expected]: | ||
| for k in data_structure.keys(): | ||
| data_structure[k] = sorted(data_structure[k], key=lambda n: n['_key']) |
There was a problem hiding this comment.
order data as it won't necessarily be sorted when coming out of the parser
ialarmedalien
commented
Aug 18, 2020
Comment on lines
+20
to
+28
| clusters: | ||
| type: array | ||
| title: Clusters | ||
| description: Clusters to which the node has been assigned | ||
| items: | ||
| type: string | ||
| format: regex | ||
| pattern: ^\w+:\d+$ | ||
| examples: [["markov_i2:1", "markov_i4:5"], ["markov_i6:3"]] |
There was a problem hiding this comment.
The important bit
ialarmedalien
commented
Aug 18, 2020
| # results are in the form {"nodes": [...], "edges": [...]} | ||
| # nodes are represented as a list of node[_key] | ||
| # edges are objects with keys _to, _from, edge_type and score | ||
|
|
||
| def test_fetch_phenotypes_no_results(self): |
There was a problem hiding this comment.
the queries with no results have been merged in with the other tests
Update parser and tests accordingly
ialarmedalien
force-pushed
the
cluster_the_clusters
branch
from
65ffbff
to
b7780a0
Compare
jayrbolton
reviewed
Aug 19, 2020
| title: Cluster IDs | ||
| description: Cluster IDs, in the form "clustering_system_name:cluster_id" | ||
| items: {type: string} | ||
| examples: [['markov_i2:5', 'markov_i6:2'],['markov_i6:1']] |
There was a problem hiding this comment.
Should this be an object so we don't have to parse these entries?
There was a problem hiding this comment.
I guess if the client is using string parameters like "markov_i2:5" then it doesn't matter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of the changes in this old PR in the relation_engine_spec repo.
Merge all
clusterfields in thedjornl_nodecollection into a single field.Update parser and tests accordingly.