Relative binning fix #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you link the previous PR so all the differences and progress can be shown at the same place? |
|
Previous PR was #40, there are only minor differences with this PR. |
|
I meant can you either pull the changes and history from the previous PR to this PR or close this one, and merge the new changes to the previous PR? I would much prefer to have all the changes in one PR instead of bouncing back and fro between two PRs |
|
Sorry for the confusion from my part, I juggled a bit with my fork. All the changes of the previous PR are also present in this PR, so you can just ignore the previous one. |
…E result still tho.
kazewong
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New pull request for #39 , after refactoring my fork of jim :) it might still break for some test cases, but at least it should fix a few things already