Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the html2js name overwrite #57

Merged
merged 1 commit into from
Jul 10, 2015
Merged

Removing the html2js name overwrite #57

merged 1 commit into from
Jul 10, 2015

Conversation

avanrielly
Copy link
Contributor

This causes issues when you need to use both pre processors

@omichelsen
Copy link

Will this be merged and released soon? Quite a few issues on this: #65, #43

@bimusiek
Copy link

When do you plan to merge this? I just spent 1 hour debugging why karma-fixtures does not work and it happened that this is the reason. 👍

@dignifiedquire dignifiedquire changed the title Eemoving the html2js name overwrite Removing the html2js name overwrite Jul 8, 2015
@dignifiedquire
Copy link
Member

Sorry for the delay, could you please update the commit message to follow our convention then I'll put this into the next release.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@avanrielly
Copy link
Contributor Author

I signed it!

I have also updated the commit message

@googlebot
Copy link

CLAs look good, thanks!

@dignifiedquire
Copy link
Member

Thanks :octocat:

dignifiedquire added a commit that referenced this pull request Jul 10, 2015
Removing the html2js name overwrite
@dignifiedquire dignifiedquire merged commit f259513 into karma-runner:master Jul 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants