Skip to content
This repository has been archived by the owner on Dec 28, 2023. It is now read-only.

Add support for full regexp --grep arguments #231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tux-rampage
Copy link

@tux-rampage tux-rampage commented Sep 18, 2020

Motivation

Some IDEs (i.e. WebStorm) pass a full regexp, including the delimitters, to karma run (See WI-55539). This will cause the runner to skip all tests instead of applying the pattern.

This PR aims to provide compatibility for this behaviour.

Example

karma run --grep=/^some\\.test\\.Suite/

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@tux-rampage
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants