fix(adapter): don't duplicate multiline failure messages #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoto13
previously approved these changes
Apr 20, 2022
There was a problem hiding this comment.
I'm not sufficiently familiar with the topic to say anything about potential implications in different browsers, but the code and reasoning look good to me. I think we can get this in as it addresses the actual bug and we can deal with any potential regressions if such arise.
The current code to handle removing error messages for formatting does not properly handle multiline error messages and results in the message being repeated at the top of the stack trace. The code only searched for the message in the first stack line, which meant it would never be found because the message was multiple lines, which meant that the message would be pre-pended by the message not in stack logic. The existing multiline test actually triggers this behavior, but because it used toMatch it only verified that the message was included, not that it only existed once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code to handle removing error messages for formatting does not
properly handle multiline error messages and results in the message being
repeated at the top of the stack trace. The code only searched for the message
in the first stack line, which meant it would never be found because the message
was multiple lines, which meant that the message would be pre-pended by the
message not in stack logic.
The existing multiline test actually triggers this behavior, but because it used
toMatch it only verified that the message was included, not that it only existed
once.