Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

singelRun - http://karma-runner.github.io/0.10/config/configuration-file.html #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

herrbaehrt
Copy link

singelRun
-- fix: use singleRun setting from config instead of hard setted to false
-- http://youtrack.jetbrains.com/issue/WEB-10788
-- markgardner/karma-sets#1

singelRun
 -- fix: use singleRun setting from config instead of hard setted to false
 -- http://youtrack.jetbrains.com/issue/WEB-10788
 -- markgardner/karma-sets#1
@segrey
Copy link
Contributor

segrey commented Jan 31, 2014

Unfortunately, WebStorm integration doesn't work with 'singleRun' set to 'true', because in that case karma server runs tests right after startup and exits after the test run. And WebStorm integration uses another workflow: it starts karma server in background and reuses it for subsequent test runs that are launched using slightly modified karma run command.

There weren't requests about supporting 'singleRun: true' so far. It would require some changes in WebStorm Karma plugin (Java code), not only JS part (i.e this repo).

About your pull request: I've applied it locally, but tests from the sample karma-sets project (attached to http://youtrack.jetbrains.com/issue/WEB-10788) can't still be run using WebStorm integration.

Meanwhile, do you consider supporting console karma run in karma-sets? I think that would also allow to run karma-sets projects in WebStorm.

Thanks,
Sergey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants