Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add istanbul ignore flag to configuration object #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add istanbul ignore flag to configuration object #50

wants to merge 1 commit into from

Conversation

westpole
Copy link

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@westpole
Copy link
Author

I signed it!

@@ -38,6 +38,7 @@ var createPreprocesor = function(logger, config, basePath) {

var output =
'window.__cjs_modules_root__ = "' + modulesRootPath + '";' +
(config.istanbul.ignore ? ' ' + config.istanbul.comment + ' ' : '') +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we make it required, depending on ignore we should either have a default or throw an error when it doesn't exist so users know what the problem is.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the idea was not to make it required. If "config.istanbul.ignore" equals to undefined or false, then output will get an empty string. So, I do not need to specify any parameter in karma configuration if I do not use istanbul coverage.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, totally right, sorry -.-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants