-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Coffeescript 2 and other changes #91
Open
prantlf
wants to merge
12
commits into
karma-runner:master
Choose a base branch
from
prantlf:coffeescript-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the deprecated package coffee-script with coffeescript. Use the version 2, which supports the version 2 of the language. BREAKING CHANGE: CoffeeScript version 2 is not 100% compatible with the version 1. See https://coffeescript.org/#breaking-changes for more information.
Replace the polyfill with the direct usage of Object.assign. BREAKING CHANGE: Upgrade Node.js to version 4 or later.
PNPM offers a better performance than NPM.
* The minimum version of Node.js to build and test this package is 12 now. * Disable some eslint warnings temporarily.
Fix eslint warnings after upgrading eslint. BREAKING CHANGE: The minimum supported version of Node.js is 8 now.
* Add a simple example of a text project. * Test the example as a unit test of the preprocessor.
Allow to install coffeescript of the particular version used in the project. BREAKING CHANGE: The package coffeescript was moved to peer dependencies. If you use a package manager with the feature parity of NPM 8, you won't notice a difference, because it will install the peer depednencies automatically. Otherwise you will need to install coffeescript as a dev dependency, like you did karma earlier.
Use c8 to compute the test code coverage.
Do not distribute development files.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And other package modernisations.
Attempts to fix #87
Attempts to fix #89