Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes, added LinkedIn, made some variables optional #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

poseen
Copy link

@poseen poseen commented Mar 22, 2023

Changes

Header

  • Optional social network links: when one is not set, then it won't appear.
  • Added LinkedIn as an option. Can be defined in site.json
    Example:
  "social": {
    "github": "fooGitHub",,
    "twitter": "fooTwitter"
    "linkedin": "fooLinkedIn"
  },

Newsletter

  • newsletter section in site.json is optional. If it wasn't present, build has failed previously.
  • Newsletter twitter link has an extra visibility condition: siteConfig.social.twitter has to be present.

Testing

Tried the following cases manually:

Header

  • Unset social.twitter --> twitter link disappeared.
  • Set social.linkedin --> LinkedIn link appeared

Newsletter

  • Removing newsletter --> build succeeds, subscription box not visible, twitter link not visible.
  • Readding newsletter, setting "showTwitterBanner": true, but unsetting social.twitter --> Twitter footer is not visible.
  • Readding newsletter, setting "showTwitterBanner": true, setting social.twitter --> Twitter footer is visible.
  • Enabling newsletter subscription box by setting newsletter.revueUsername --> Subscription box is visible, twitter footer is invisible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant