Minor fixes, added LinkedIn, made some variables optional #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Header
site.json
Example:
Newsletter
newsletter
section insite.json
is optional. If it wasn't present, build has failed previously.siteConfig.social.twitter
has to be present.Testing
Tried the following cases manually:
Header
social.twitter
--> twitter link disappeared.social.linkedin
--> LinkedIn link appearedNewsletter
newsletter
--> build succeeds, subscription box not visible, twitter link not visible.newsletter
, setting"showTwitterBanner": true
, but unsettingsocial.twitter
--> Twitter footer is not visible.newsletter
, setting"showTwitterBanner": true
, settingsocial.twitter
--> Twitter footer is visible.newsletter.revueUsername
--> Subscription box is visible, twitter footer is invisible.