Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 17 #2093

Merged
merged 9 commits into from
Nov 22, 2023
Merged

Angular 17 #2093

merged 9 commits into from
Nov 22, 2023

Conversation

PowerKiKi
Copy link
Collaborator

Fixes #2090

Copy link

changeset-bot bot commented Nov 13, 2023

🦋 Changeset detected

Latest commit: 110a7fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
apollo-angular Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@PowerKiKi PowerKiKi marked this pull request as draft November 13, 2023 09:47
Copy link
Contributor

github-actions bot commented Nov 13, 2023

💻 Website Preview

The latest changes are available as preview in: https://8f47fb3a.apollo-angular.pages.dev

@rezoled
Copy link

rezoled commented Nov 13, 2023

FYI, updating the project to Angular 17 and running it causes tests to break.
Here is a PR with the fixed code: #2094

Copy link
Contributor

github-actions bot commented Nov 14, 2023

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
apollo-angular 6.0.0-alpha-20231122031041-110a7fd4 npm ↗︎ unpkg ↗︎

@PowerKiKi
Copy link
Collaborator Author

PowerKiKi commented Nov 14, 2023

@MerlinMoos, @rezoled, thank you both for your contribution. I see we all worked at the same time on a very similar solution. I am trying to consolidate everything in this PR. Feel free to let me know if you think I forgot something.

@PowerKiKi
Copy link
Collaborator Author

I am having trouble with the error Project target "build" not found., if somebody has an idea...

@rezoled
Copy link

rezoled commented Nov 14, 2023

Did you try my PR?
#2094 (comment)
I ran all the tests successfully on my local machine

@PowerKiKi
Copy link
Collaborator Author

Unfortunately your PR did not run successfully for all Angular versions: https://github.com/kamilkisiela/apollo-angular/actions/runs/6849193747

In this PR, I dropped support for Angular 14 , 15 and 16 because of that.

I am considering dropping schematics if those prove too time-consuming to maintain (@kamilkisiela an opinion about that ?)

@rezoled
Copy link

rezoled commented Nov 14, 2023

I removed angular 14,15,16 support, can you try to run the tests again? I'm not sure why it even failed.
Here is the new PR: #2103

PowerKiKi and others added 3 commits November 22, 2023 09:39
- fixed zone.js test import
- fixed tests to run according to new Schematics file tree
- moved away from deprecated runSchematicAsync and runExternalSchematicAsync
- fix ng add schematics for standalone apps

Fixes #2090
@PowerKiKi PowerKiKi marked this pull request as ready for review November 22, 2023 03:14
@PowerKiKi PowerKiKi merged commit a15dd2c into master Nov 22, 2023
12 checks passed
@PowerKiKi PowerKiKi deleted the powerkiki branch November 22, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 17 support
4 participants