-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 17 #2093
Angular 17 #2093
Conversation
🦋 Changeset detectedLatest commit: 110a7fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
💻 Website PreviewThe latest changes are available as preview in: https://8f47fb3a.apollo-angular.pages.dev |
FYI, updating the project to Angular 17 and running it causes tests to break. |
@MerlinMoos, @rezoled, thank you both for your contribution. I see we all worked at the same time on a very similar solution. I am trying to consolidate everything in this PR. Feel free to let me know if you think I forgot something. |
I am having trouble with the error |
Did you try my PR? |
Unfortunately your PR did not run successfully for all Angular versions: https://github.com/kamilkisiela/apollo-angular/actions/runs/6849193747 In this PR, I dropped support for Angular 14 , 15 and 16 because of that. I am considering dropping schematics if those prove too time-consuming to maintain (@kamilkisiela an opinion about that ?) |
I removed angular 14,15,16 support, can you try to run the tests again? I'm not sure why it even failed. |
- fixed zone.js test import - fixed tests to run according to new Schematics file tree - moved away from deprecated runSchematicAsync and runExternalSchematicAsync - fix ng add schematics for standalone apps Fixes #2090
Because it is obsolete, unmaintained and would probably break things with standalone
Fixes #2090