Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-10608): safari doesn't enter to buffering on seek. #493

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Oct 21, 2020

Description of the Changes

Issue: the player doesn't enter to buffering state on safari on seeking.
Solution: keep the state after seeked on buffering which will change on playing only.
don't fire playing on seeking, only after video already seeked.
verified there isn't a regression of - #100.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

Issue: player doesn't enter to buffering state on safari on seek.
Solution: keep the state after seeked on buffering which will change on playing only.
don't fire playing on seeking, only after video already seeked.
verified no regression of -#100.
@Yuvalke Yuvalke requested a review from a team October 21, 2020 09:24
@Yuvalke Yuvalke self-assigned this Oct 21, 2020
@Yuvalke Yuvalke changed the title fix: safari doesn't enter to buffering on seek. fix(FEC-10608): safari doesn't enter to buffering on seek. Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant