Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-12600): player should support referer without scheme part #4301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lianbenjamin
Copy link
Collaborator

@lianbenjamin lianbenjamin commented Sep 28, 2022

the issue:
sometimes referer header might not include "http" or "https" (i.e. kaltura.com). in this case, if kaltura.com is an allowed domain in an ACP, it will not be recognized by the player, since the player is looking for scheme part (http/s) and host part. we are using a php function called parse_url to break the referer header into url parts. in cases where the referer does not contain a scheme part (http/s), there is also no host, but path exists instead.

solution:
when building the referer, adding another check for path attribute.

Solves FEC-12600

@PlaykitJs-Bot
Copy link

Live Pull Request Urls

@giladna giladna requested a review from OrenMe September 29, 2022 13:54
@giladna
Copy link
Contributor

giladna commented Sep 29, 2022

@OrenMe
could you please look at this PR and put your concernes if any regarding the fix
as usually valid referrer should come with schema and here we try to change the behaviour

Base automatically changed from 2.98 to master January 3, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants